Updated install-deps to make it work for Zorin OS also #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency installation script was not functioning on Zorin because previous script was unable to extract distro name and it extracted version number as (Zorin 12 runs on a Ubuntu 16 backend). Hence, even with hardcoding distro name as ubuntu, it would run the script for Ubuntu 12. Hence, I have provided an alternative for distro name and version detection, and also added code specific for installation on Zorin testing. I have tested the code and it works on my Zorin Core 12.
Also, my previous pull request was on a vanilla Ubuntu 16.04 system, and it works there. I have updated that in the readme.